Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(me): add support for SSO configuration #494

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat(me): add support for SSO configuration #494

wants to merge 6 commits into from
+735 −0

Conversation

psauvage0
Copy link
Contributor

@psauvage0 psauvage0 commented Nov 10, 2023 •
edited
Loading

Description

This PR adds support for the /me/identity/provider routes of the API, which handle the configuration of SSO.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: TF_ACC=1 go test -v ./... -run 'TestAccMeIdentityProvider.*'"

Test Configuration:

  • Terraform version: terraform version: Terraform v1.6.2
  • Existing HCL configuration you used:
    group_attribute_name = "http://schemas.xmlsoap.org/claims/Group"
    metadata = <<EOT
<?xml version="1.0" encoding="UTF-8"?>
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="https://ovhcloud.com/">
  <IDPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol">
    <KeyDescriptor use="signing">
      <KeyInfo xmlns="http://www.w3.org/2000/09/xmldsig#">
        <X509Data>
          <X509Certificate>MIIFlTCCA32gAwIBAgIUP8WQwHQwrvTa00RU9JROZAJj9ccwDQYJKoZIhvcNAQELBQAwWjELMAkGA1UEBhMCRlIxEzARBgNVBAgMClNvbWUtU3RhdGUxDDAKBgNVBAcMA1JCWDERMA8GA1UECgwIT1ZIY2xvdWQxFTATBgNVBAMMDG92aGNsb3VkLmNvbTAeFw0yMzExMDkxMDA2MjRaFw0zMzExMDYxMDA2MjRaMFoxCzAJBgNVBAYTAkZSMRMwEQYDVQQIDApTb21lLVN0YXRlMQwwCgYDVQQHDANSQlgxETAPBgNVBAoMCE9WSGNsb3VkMRUwEwYDVQQDDAxvdmhjbG91ZC5jb20wggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQC4V3HulFBksxpgkgR6KgDaSSIKkKRgyDGCF06oQN/WPxGDSHTQQHTMN7jnsbr2uJieNKh+iasGvE9JFmd6nutloL1UHoO/ecrE8P2PYgpgezl7WfyoscBDZAjWM8E9FdENnonhvlga2DgV2DGIB4+D7aN6TIPfWukOB2MjfQloA9Iw71+peO9R55S7x7zixgpLO9NovbmaAyClbz06Tsm/7ezM+Vte7BfFqGUnwuNzqgOYfQm88EqXTpCT3QfR8i2IydGgAFLMFs9YvMnCaNLw9PCN7U6VPkY6M6cFQhO/moRb3H/euJnLNRMsXp99K8ruUnQ6902NXpOOnQu5Ewzfahmx0WWvlpFGdJK34oXjaWeTodGuvHtDxCY4tiHr8jCHf9h4cmC20xAyd/V7XBtu1Pc5UAg4I0w5ehWvHtVdxCsuPEh7c4qtuLyN9Qh15r+eRbiqnWTH/xJTwfo6q6iafXXcFOlTn7WoWmmeq0R8whg6XjcxMIzBXjtynTDbQa4LVq3T8iJiGfuDgwv5OwDPRN1CsawxefETsCUQ+jf/Iw/4nZpD/YqCI5xvYtDgPSt3v2TsoOnwOSjOqKmEOoHxGTN3mhbcD+I1QKJW79zqu6GVXVwMkgWdP4pkIWGccB0FqhIVzY19xQ40DbfnCkMTv2XN4t53c/q7CYhtvyN3XwIDAQABo1MwUTAdBgNVHQ4EFgQUC8yuX4Ub/Od5jSaz7NdwHUSlq5wwHwYDVR0jBBgwFoAUC8yuX4Ub/Od5jSaz7NdwHUSlq5wwDwYDVR0TAQH/BAUwAwEB/zANBgkqhkiG9w0BAQsFAAOCAgEAR4MzroH8kEwqcZeB94hetY/NQGZI+kZ26iKnvLaZa8r56UeiIrEGdEeys5JdQh/XJDWsEU6piJ0dwrIkkpgZELmUmToylcxndzjjcHbiKLlqkL+kBu9QeO/r6JTHaNyWs0An2VvCUfo+Frt8hvrJCINlCDylOaWIxHH3P0TG7ThFGWSy8nW+VMMXDS8vQIGRM66HqgYlu6HBryecf0SsCkVYbUb1zYJ+lEhYK0pj4RORainJX+PU+mIMUwQtfBByuI7RP0a2Vny0gffrtPuNfhRJb8Pwt2UYw2niWUDOfXuk9RYgqX/1wLVqk72KJJlD3c7+abZ6BcNEJax5e/icilUrxcs4MymDPjk63kQURRVzcC4hCXYqJVQmRfVT4fdLLKPmeg3ysl+U4eJZ8odmaqoVGqZryncdAC+nT5lnLRm6m2lv3v+YhConctLxzCwV/xA8jU2w9VVRw2gkY8bdkvOb7c2OpXU6J3TYtaltG7foQiuXbRd37GWzzzEspxiAI9y8uIEJTsASaufsEdpR+a1sPy3rYJom/Li3dH9p9Ch+tp51pMYhSRGEiNu9g5918zMbrKvwkl6h/PQlTOlb65qUUoNKC5Baxhz3VkGxSKMUwS4Lj/WHvCGU5OteGFHglDgDm125FDakOYU1dnMm/P55yNhnSUH2sXngybxnw/w=</X509Certificate>
        </X509Data>
      </KeyInfo>
    </KeyDescriptor>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:persistent</NameIDFormat>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="https://ovhcloud.com/"></SingleSignOnService>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="https://ovhcloud.com/"></SingleSignOnService>
  </IDPSSODescriptor>
</EntityDescriptor>
EOT
    disable_users = false
    requested_attributes {
      is_required = false
      name = "group"
      name_format = "urn:oasis:names:tc:SAML:2.0:attrname-format:basic"
      values = ["test"]
    }
    requested_attributes {
      is_required = false
      name = "aaa"
      name_format = "urn:oasis:names:tc:SAML:2.0:attrname-format:basic"
      values = ["bbb"]
    }
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@psauvage0 psauvage0 force-pushed the dev/psauvage/UIAM-591/add-sso-management branch from c380e1e to 3ee38c9 Compare November 10, 2023 16:11
@fehrnah fehrnah requested a review from yomovh November 13, 2023 09:20
@psauvage0 psauvage0 force-pushed the dev/psauvage/UIAM-591/add-sso-management branch from 23ec443 to a8ca662 Compare November 23, 2023 10:39
@rbeuque74 rbeuque74 self-requested a review November 23, 2023 10:53
rbeuque74
rbeuque74 requested changes Nov 23, 2023
View reviewed changes
ovh/types_me.go Outdated Show resolved Hide resolved
website/docs/r/me_identity_provider.html.markdown Outdated Show resolved Hide resolved
website/docs/r/me_identity_provider.html.markdown Outdated Show resolved Hide resolved
website/docs/r/me_identity_provider.html.markdown Outdated Show resolved Hide resolved
website/docs/r/me_identity_provider.html.markdown Outdated Show resolved Hide resolved
ovh/resource_me_identity_provider.go Show resolved Hide resolved
ovh/resource_me_identity_provider.go Outdated Show resolved Hide resolved
ovh/resource_me_identity_provider.go Outdated Show resolved Hide resolved
ovh/types_me.go Outdated Show resolved Hide resolved
@rbeuque74
Copy link
Member

On hold until we find a good way to test it.

If unclear, to check with me before merging or launching test in CI on this one.

  • Wait

@rbeuque74 rbeuque74 self-assigned this Dec 13, 2023
@rbeuque74 rbeuque74 marked this pull request as draft December 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoakes Stoakes Stoakes left review comments

@rbeuque74 rbeuque74 rbeuque74 requested changes

@yomovh yomovh Awaiting requested review from yomovh yomovh is a code owner

@deathiop deathiop Awaiting requested review from deathiop deathiop will be requested when the pull request is marked ready for review deathiop is a code owner

@amstuta amstuta Awaiting requested review from amstuta amstuta will be requested when the pull request is marked ready for review amstuta is a code owner

@mxpetit mxpetit Awaiting requested review from mxpetit mxpetit will be requested when the pull request is marked ready for review mxpetit is a code owner

@marie-j marie-j Awaiting requested review from marie-j marie-j will be requested when the pull request is marked ready for review marie-j is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@rbeuque74 rbeuque74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psauvage0 @rbeuque74 @Stoakes